Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename and possibly refactor the inner types of IterByColRange #2116

Open
bfops opened this issue Jan 13, 2025 · 1 comment
Open

Rename and possibly refactor the inner types of IterByColRange #2116

bfops opened this issue Jan 13, 2025 · 1 comment

Comments

@bfops
Copy link
Collaborator

bfops commented Jan 13, 2025

pub enum IterByColRange<'a, R: RangeBounds<AlgebraicValue>> {
    /// When the column in question does not have an index.
    Scan(ScanIterByColRange<'a, R>),

    /// When the column has an index, and the table
    /// has been modified this transaction.
    Index(IndexSeekIterInner<'a>),

    /// When the column has an index, and the table
    /// has not been modified in this transaction.
    CommittedIndex(CommittedIndexIter<'a>),
}

The types here could have better names. Also does it need to be explicitly parameterized with a range or should it agnostic to the type of index?

@bfops
Copy link
Collaborator Author

bfops commented Jan 13, 2025

Would this affect the API at all?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant