Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compatibility with matcher-combinators #546

Merged
merged 1 commit into from
Oct 2, 2018

Conversation

plexus
Copy link
Contributor

@plexus plexus commented Sep 25, 2018

Currently when running a test through cider, any failures in a
(is (match? ,,,)) clause will be silently ignores.

This detects mismatch messages and treats them as failure messages. Where there
is a mismatch the user will see a {:expected x :actual y} in the test output.

@plexus
Copy link
Contributor Author

plexus commented Sep 25, 2018

This is a logical follow-up to #510, where it was mentioned that matcher-combinators should use a namespaced keyword for its custom message type, which is does since nubank/matcher-combinators#34.

@bbatsov
Copy link
Member

bbatsov commented Sep 25, 2018

@plexus LGTM.

Can you please mention this in the changelog as well?

Maybe also add that bit of documentation that was discussed in #510 as well for future reference.

Currently when running a test through cider, any failures in a
`(is (match? ,,,))` clause will be silently ignores.

This detects mismatch messages and treats them as failure messages. Where there
is a mismatch the user will see a {:expected x :actual y} in the test output.
@plexus plexus force-pushed the support-matcher-combinators branch from 50c500d to dc44d53 Compare October 1, 2018 18:59
@codecov
Copy link

codecov bot commented Oct 1, 2018

Codecov Report

Merging #546 into master will decrease coverage by 0.05%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #546      +/-   ##
==========================================
- Coverage   73.07%   73.02%   -0.06%     
==========================================
  Files          36       36              
  Lines        2366     2369       +3     
  Branches      137      137              
==========================================
+ Hits         1729     1730       +1     
- Misses        500      502       +2     
  Partials      137      137
Impacted Files Coverage Δ
src/cider/nrepl/middleware/test.clj 57.89% <33.33%> (-0.4%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b2cc29...dc44d53. Read the comment docs.

@plexus
Copy link
Contributor Author

plexus commented Oct 1, 2018

I've updated the CHANGELOG. Which documentation are you refering to @bbatsov? There's already a bit about extensibility in the docs. Or do you mean this exchange? I'm not sure what the conclusion from that is...

@bbatsov
Copy link
Member

bbatsov commented Oct 1, 2018

@plexus I was referring to:

@xiongtx I'm guessing we should add some integration notes in CIDER's manual, otherwise people are going to have a hard time figuring out what they are supposed to do.

(meaning documenting how to extend report, but that's not a big deal)

@bbatsov bbatsov merged commit b2c0b92 into clojure-emacs:master Oct 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants