Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cider 0.21 miscolors some output at the REPL seemingly randomly, maybe fixed in 0.22 snapshot #2660

Closed
joinr opened this issue Jun 25, 2019 · 1 comment

Comments

@joinr
Copy link

joinr commented Jun 25, 2019

Expected behavior

Cider's syntax highlighting in prior releases has consistently provided a nice visual
discriminator for data structures. Collection delimiters are white, keywords are green,
numbers are white, strings are red, etc.

This should be consistent regardless of the output.

Actual behavior

When some output is printed at the REPL, the syntax highlighting seemingly "breaks"
for chunks of the output for unknown reasons. There seems to be an error somewhere
that parses (or partially parses) the output and infers it's a string, leaving the bulk of
the output to be red, with small portions (after a ") as white. This is inconsistent and
indicative of an error in the syntax highlighting implementation.

shown here

Steps to reproduce the problem

Given the file miscolored.edn, this problem emerges with a simple read:

(clojure.edn/read-string (slurp "miscolored.edn"))

Which, when printed through the REPL, should result in the image above (the last element is majority red).

Environment & Version information

CIDER version information

;; CIDER 0.21.0 (New York), nREPL 0.6.0
;; Clojure 1.10.0, Java 1.8.0_181

Lein/Boot version

Leiningen 2.9.1 on Java 1.8.0_181 Java HotSpot(TM) 64-Bit Server VM

Emacs version

25.3.1

Operating system

Windows 10

Addendum

I also tested this using spacemacs on an ubuntu remote machine. Since spacemacs clojure layer updates more frequently, I unintentionally had a snapshot release of 0.22 installed.

The picture here demonstrates expected output under spacemacs with cider 0.22.0 snapshot (package 20190515.946) under spacemacs using the same input miscolored.edn.

I'm uncertain if the issue is platform dependent (windows vs. linux) or if 0.22 has fixed it.

@bbatsov
Copy link
Member

bbatsov commented Jun 26, 2019

That's a duplicate of #2628. I'm afraid it's not fixed yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants