Fix cider-eval-defun-up-to-point incorrectly matching brackets

[LuisThiamNye]

Consider:

(prn 1 [2 {3 4|} 5] 6)

If | represents the cursor, and then I run cider-eval-defun-up-to-point, CIDER attempts to evaluate (prn 1 [2 {3 4|)]} resulting in an exception.

I also get the issue in a comment block:

(comment
  (prn 5|)
)

...which results in the evaluation of (prn 5)) — there is an extra closing delimiter as cider--calculate-closing-delimiters looks beyond the prn form and matches the ( of the comment form. I would expect the evaluation of (prn 5).

In this patch I have integrated modified functions that appear to have solved this problem for me.

The code for the new cider--insert-closing-delimiters is an adaptation of the cider-repl-closing-return function. Perhaps cider-repl-closing-return should depend on the more general cider--insert-closing-delimiters?

In one commit I have removed functions that seem to have been made redundant.

---

• The commits are consistent with our contribution guidelines
• You've added tests (if possible) to cover your change(s)
• All tests are passing (eldev test)
• All code passes the linter (eldev lint) which is based on elisp-lint and includes
  • byte-compilation, checkdoc, check-declare, packaging metadata, indentation, and trailing whitespace checks.
• You've updated the changelog (if adding/changing user-visible functionality)
• You've updated the user manual (if adding/changing user-visible functionality)

[bbatsov]

Perhaps cider-repl-closing-return should depend on the more general cider--insert-closing-delimiters?

Yeah, you're probably right about it. It simply predates the cider--insert-closing-delimiters function.

Overall your changes look good; I left only a couple of small remarks.

[bbatsov]

Thanks for the quick follow-up! 🙇‍♂️