Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong unit used in human readable #4

Closed
BrunoBonacci opened this issue Oct 14, 2018 · 1 comment
Closed

Wrong unit used in human readable #4

BrunoBonacci opened this issue Oct 14, 2018 · 1 comment
Labels
bug Something isn't working

Comments

@BrunoBonacci
Copy link

Very nice library!!.

Browsing the code I spotted a little issue in convert-to-human-readable at:

Historically 1KB was 1024 bytes, however since these measures have been incorporated in the International System of Units (SI) they have been uniformed with the other measures where 1 KB = 1000 bytes and 1 MB is 1000000. The power of 2 unit of 1024 it is now referred as KiB, MiB, GiB etc

Please see the following article.
https://en.wikipedia.org/wiki/Megabyte

So it is adviseable that you either update the unit to 1000 or the labels to MiB instead of MB.

@alexander-yakushev
Copy link
Member

Good point! Thanks, Bruno. I've pushed a fix.

@alexander-yakushev alexander-yakushev added the bug Something isn't working label Oct 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

No branches or pull requests

2 participants