Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ripsaw cli k8s client does not honor proxy settings #311

Closed
mffiedler opened this issue Jan 27, 2022 · 2 comments
Closed

ripsaw cli k8s client does not honor proxy settings #311

mffiedler opened this issue Jan 27, 2022 · 2 comments

Comments

@mffiedler
Copy link
Contributor

mffiedler commented Jan 27, 2022

In clusters accessible only via proxy, the e2e-benchmark tests using the ripsaw cli fail when oc otherwise works. The client needs to be updated to configure the kubernetes.client with the proxy. Something like this, I think:

    config.load_kube_config(config_file=kubeconfig_path)
    proxy_url = os.getenv('http_proxy', None)
    if proxy_url:
       client.Configuration._default_proxy = proxy_url
    self.api_client = client.ApiClient()

I will try to put up a PR if I can figure out how to test ripsaw CLI changes locally (easily)

@mffiedler
Copy link
Contributor Author

Reference: kubernetes-client/python#333 (comment)

@mffiedler
Copy link
Contributor Author

wrong repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant