Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

module input / output with nested modules #194

Closed
kapilt opened this issue Apr 9, 2024 · 2 comments
Closed

module input / output with nested modules #194

kapilt opened this issue Apr 9, 2024 · 2 comments

Comments

@kapilt
Copy link
Contributor

kapilt commented Apr 9, 2024

#185 attempted to address this but the solution doesn't work for nested modules

ie. root module contains module a and module b, feeding output of a to b, but module b has a two child modules c and d, that it tries to pass through outputs from module a as inputs to c and d. currently it appears those inputs in module c and d appear blank.
@kapilt
Copy link
Contributor Author

kapilt commented Apr 9, 2024

Previous pr has some additional context

#187

This was referenced Apr 22, 2024
Closed
Merged
@ajkerrigan
Copy link
Member

Looks like #195 had some additional changes/fixes/tests to cover this case. Nested modules appear to work as expected now.

@kapilt kapilt mentioned this issue Jun 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kapilt @ajkerrigan