Add a "Remove all space roles" button #1164

rememberlenny · 2017-07-24T21:46:12Z

jcscottiii · 2017-07-25T13:09:17Z

static_src/constants.js

@@ -270,6 +270,10 @@ const userActionTypes = keymirror({
  USER_INVITE_ERROR: null,
  // Action to dismiss an user list notification.
  USER_LIST_NOTICE_DISMISSED: null,
+  // Action to remove all roles for space user.
+  USER_REMOVE_ALL_SPACE_ROLES: null,
+  // Action to removed all roles for space user.


Action when all roles removed from space user

jcscottiii · 2017-07-25T13:16:22Z

static_src/stores/user_store.js

@@ -164,6 +164,13 @@ export class UserStore extends BaseStore {
        break;
      }

+      case userActionTypes.USER_REMOVED_ALL_SPACE_ROLES: {


only need one more test. that it changes the list of users upon removing the person.

there's similar tests for the store for the add or delete cases.

jcscottiii

nice PR! just two minor changes

jcscottiii · 2017-07-25T14:34:36Z

static_src/constants.js

@@ -270,6 +270,10 @@ const userActionTypes = keymirror({
  USER_INVITE_ERROR: null,
  // Action to dismiss an user list notification.
  USER_LIST_NOTICE_DISMISSED: null,
+  // Action when all roles for space user are removed.


oops i think i told you to put that comment on the wrong constant. i meant the one below should be the Action when all...

this first one should be Action to...

rememberlenny added 5 commits July 24, 2017 17:07

Add the user action constants for removing all roles at a space level

60a1f3a

Create the response to a user role change, so the UI updates

f17dfb1

Create new user actions so that the user role changes can be replied to

2dfc222

Add space based action items

459529e

Create working tests

011a03b

rememberlenny requested a review from jcscottiii July 24, 2017 21:46

jcscottiii reviewed Jul 25, 2017

View reviewed changes

jcscottiii suggested changes Jul 25, 2017

View reviewed changes

rememberlenny added 3 commits July 25, 2017 10:17

Save the changes around the constants

dce8cf7

Add a test to check for user manipulation

1c9a47d

Create the space check and remove handling

ff7fe55

rememberlenny force-pushed the lkb-add-remove-space-on-user branch from cf7a328 to ff7fe55 Compare July 25, 2017 14:24

jcscottiii reviewed Jul 25, 2017

View reviewed changes

Move the comment to correct action

2c2b8d4

jcscottiii approved these changes Jul 25, 2017

View reviewed changes

rememberlenny merged commit e58edf4 into master Jul 25, 2017

rememberlenny deleted the lkb-add-remove-space-on-user branch July 25, 2017 14:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add a "Remove all space roles" button #1164

Add a "Remove all space roles" button #1164

rememberlenny commented Jul 24, 2017

jcscottiii Jul 25, 2017

jcscottiii Jul 25, 2017

jcscottiii Jul 25, 2017

jcscottiii left a comment

jcscottiii Jul 25, 2017 •

edited

Loading

jcscottiii Jul 25, 2017

rememberlenny Jul 25, 2017

Add a "Remove all space roles" button #1164

Add a "Remove all space roles" button #1164

Conversation

rememberlenny commented Jul 24, 2017

jcscottiii Jul 25, 2017

Choose a reason for hiding this comment

jcscottiii Jul 25, 2017

Choose a reason for hiding this comment

jcscottiii Jul 25, 2017

Choose a reason for hiding this comment

jcscottiii left a comment

Choose a reason for hiding this comment

jcscottiii Jul 25, 2017 • edited Loading

Choose a reason for hiding this comment

jcscottiii Jul 25, 2017

Choose a reason for hiding this comment

rememberlenny Jul 25, 2017

Choose a reason for hiding this comment

jcscottiii Jul 25, 2017 •

edited

Loading