This repository has been archived by the owner on May 19, 2020. It is now read-only.
Add user check org org manager #1202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rememberlenny
force-pushed
the
lkb-roles-as-orgman
branch
from
2c48b3a to
d27f9cf
Compare
jcscottiii
suggested changes
Aug 25, 2017
static_src/components/users.jsx
Outdated
| @@ -230,11 +234,16 @@ export default class Users extends React.Component { | |||
| get userParentEntityUserSelector() { | |||
| // only show something if in a space and if the user is a org manager | |||
| // or space manager. | |||
| if (!this.isSpace || | |||
There was a problem hiding this comment.
could you revert this change and line 241-245
el-mapache
previously approved these changes
Aug 25, 2017
static_src/components/users.jsx
Outdated
| return null; | ||
| } | ||
|
|
||
| if (!this.currentUserIsOrgManager) { |
There was a problem hiding this comment.
could this be !this.currentUserIsOrgManager && !this.currentUserIsSpaceManager?
EDIT: I see from the deleted lines it could, maybe revert the change as @jcscottiii suggests but move the logic to a method?
rememberlenny
force-pushed
the
lkb-roles-as-orgman
branch
from
4e4cd93 to
f759107
Compare
rememberlenny
force-pushed
the
lkb-roles-as-orgman
branch
from
f759107 to
2e30185
Compare
jcscottiii
approved these changes
Aug 25, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.