This repository has been archived by the owner on Mar 6, 2023. It is now read-only.
Use localhost to fetch checksums #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid fetching checksums on every node by delegating the checksum fetch to localhost. Fixes: #165 [fix] Signed-off-by: Ben Kochie <superq@gmail.com>
paulfantom
reviewed
Jul 20, 2020
| @@ -107,4 +107,5 @@ | |||
| with_items: "{{ _checksums }}" | |||
| when: | |||
| - "('linux-' + go_arch + '.tar.gz') in item" | |||
| delegate_to: localhost | |||
There was a problem hiding this comment.
What will happen in mixed arch environment, when go_arch on one host is different from go_arch on the other?
There was a problem hiding this comment.
Yes, it still works, same way the binary download works with delegate_to and go_arch. The Ansible facts are per-node.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid fetching checksums on every node by delegating the checksum fetch
to localhost.
Fixes: #165
[fix]
Signed-off-by: Ben Kochie superq@gmail.com