This repository has been archived by the owner on Mar 6, 2023. It is now read-only.
optionally allow node_exporter access to shared /tmp #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/jinja
paulfantom
suggested changes
Sep 3, 2020
defaults/main.yml
Outdated
| @@ -20,3 +20,4 @@ node_exporter_enabled_collectors: | |||
| # ignored-fs-types: "^(sys|proc|auto)fs$" | |||
|
|
|||
| node_exporter_disabled_collectors: [] | |||
| node_exporter_private_tmp: true | |||
There was a problem hiding this comment.
I would prefer if this wasn't conditional as we intend to allow permissions to run most node_exporter collectors without tinkering with permissions.
Could you hardcode it?
When node_exporter service is configured to use private /tmp, it can no longer access mount points under /tmp either - node_exporter will log errors, bump node_filesystem_device_error metric and skip metrics related to that mount point.
|
Thanks 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
by default node_exporter.service sets PrivateTmp=yes which prevents
node_exporter from monitoring the actual /tmp, e.g. for children mount
points.