This repository has been archived by the owner on Mar 6, 2023. It is now read-only.
Add support for textfile collector #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SuperQ
force-pushed
the
superq/textfile
branch
3 times, most recently
from
dd54aef
to
eb43a65
Compare
paulfantom
reviewed
Jun 10, 2018
defaults/main.yml
Outdated
| @@ -2,8 +2,12 @@ | |||
| node_exporter_version: 0.16.0 | |||
| node_exporter_web_listen_address: "0.0.0.0:9100" | |||
|
|
|||
| node_exporter_textfile_dir: "/opt/node_exporter/textfile" | |||
There was a problem hiding this comment.
Shouldn't it be somewhere in /var? Maybe in /var/local?
There was a problem hiding this comment.
I'd say '/var/lib`, how about that?
tasks/main.yml
Outdated
| group: "node-exp" | ||
| recurse: true | ||
| mode: 0755 | ||
| when: node_exporter_textfile_dir is defined |
There was a problem hiding this comment.
It will always be defined since it is set in defaults/main.yml. Better to check if it is not empty (node_exporter_textfile_dir != "").
[feature] Create a default textfile collector directory and enable it by default.
|
@paulfantom Fixed up, PTAL. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[feature]
Create a default textfile collector directory and enable it by default.