This repository has been archived by the owner on Mar 6, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Which requires no dependencies.
bswinnerton
commented
Sep 17, 2018
I don't have push access to this repository, so I can't rebuild jobs in Travis. I closed and reopened the pull request to trigger a new webhook to be pushed to Travis. Once I did, I noticed a failure:
I've opened a pull request in paulfantom/dockerfiles#3 to resolve the |
Going to close and reopen the PR one more time to kick off a new CI build. |
This is especially helpful for Clear Linux which may not already have the directory.
This helps with Clear Linux when using Ansible 2.4. Once support is dropped for 2.4, this line will no longer be needed. When using Clear Linux with Ansible 2.4, you would see facts that look like this: ``` root@3ca7751f8d6c / # ansible -m setup localhost | grep distribution [WARNING]: Unable to parse /etc/ansible/hosts as an inventory source [WARNING]: No inventory was parsed, only implicit localhost is available [WARNING]: Could not match supplied host pattern, ignoring: all [WARNING]: provided hosts list is empty, only localhost is available "ansible_distribution": "NAME=\"Clear", "ansible_distribution_file_parsed": true, "ansible_distribution_file_path": "/usr/lib/os-release", "ansible_distribution_file_variety": "ClearLinux", "ansible_distribution_major_version": "25020", "ansible_distribution_release": "clear-linux-os", "ansible_distribution_version": "25020", ``` Oddly, the `ansible_distribution` (and `ansible_os_family`) is not correct, but _is_ correct in subsequent versions like 2.5 and 2.6: ``` root@3ca7751f8d6c / # ansible -m setup localhost | grep distribution [WARNING]: Unable to parse /etc/ansible/hosts as an inventory source [WARNING]: No inventory was parsed, only implicit localhost is available [WARNING]: provided hosts list is empty, only localhost is available. Note that the implicit localhost does not match 'all' "ansible_distribution": "ClearLinux", "ansible_distribution_file_parsed": true, "ansible_distribution_file_path": "/usr/lib/os-release", "ansible_distribution_file_search_string": "Clear Linux", "ansible_distribution_file_variety": "ClearLinux", "ansible_distribution_major_version": "25020", "ansible_distribution_release": "clear-linux-os", "ansible_distribution_version": "25020", root@3ca7751f8d6c / # ansible -m setup localhost | grep ansible_os [WARNING]: Unable to parse /etc/ansible/hosts as an inventory source [WARNING]: No inventory was parsed, only implicit localhost is available [WARNING]: provided hosts list is empty, only localhost is available. Note that the implicit localhost does not match 'all' "ansible_os_family": "ClearLinux", ``` This commit updates the vars to use something that will support Clear Linux with Ansible version 2.4.
@paulfantom, I know you had requested to rebase against |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building on paulfantom/dockerfiles#2, this pull request adds support for Clear Linux, a lightweight auto-updating distribution of Linux.
Clear Linux has one dependency: the
sysadmin-basic
"bundle". Bundles are how packages are installed in Clear Linux, andsysadmin-basic
includesgetcap
. This dependency was added to thevars/clearlinux.yml
file.I also had to add a task to ensure that
/usr/local/bin
is present, as it's not always in Clear Linux.And lastly, as outlined in 94c3edd, I had to update the
with_first_round
to useansible_distribution_file_variety
, due to the way that Clear Linux returnsansible_distribution
/ansible_os_family
values for Ansible 2.4. Once support for Ansible 2.4 is dropped, we can remove that line.