Skip to content
This repository has been archived by the owner on Mar 6, 2023. It is now read-only.

simplify automated CPU arch choosing #64

Merged
merged 2 commits into from
Dec 17, 2018
Merged

simplify automated CPU arch choosing #64

merged 2 commits into from
Dec 17, 2018

Conversation

paulfantom
Copy link
Member

Instead of using {{ go_arch_map[ansible_architecture] | default(ansible_architecture) }} everywhere just map it to a variable and use this variable.

@paulfantom paulfantom changed the title [WIP] simplify automated CPU arch choosing simplify automated CPU arch choosing Dec 16, 2018
vars/main.yml Outdated Show resolved Hide resolved
Copy link
Collaborator

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Nice

@SuperQ
Copy link
Collaborator

SuperQ commented Dec 17, 2018

We should also start adding these basic changes to the skeleton first. ;-)

@paulfantom
Copy link
Member Author

You're right. I already modifiied skeleton to include this change: cloudalchemy/skeleton@6831ab6 :)

@paulfantom paulfantom merged commit 8925f49 into master Dec 17, 2018
@paulfantom paulfantom deleted the cpu_arch branch December 17, 2018 09:06
@lock
Copy link

lock bot commented Mar 24, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Mar 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants