Skip to content
This repository has been archived by the owner on Mar 6, 2023. It is now read-only.

Optimizations #67

Closed
till opened this issue Jan 6, 2019 · 6 comments
Closed

Optimizations #67

till opened this issue Jan 6, 2019 · 6 comments
Labels
wontfix This will not be worked on

Comments

@till
Copy link
Contributor

till commented Jan 6, 2019

(Sorry, for lack of better headline/title...)

I had a question about this role, specifically about:
https://github.com/cloudalchemy/ansible-node-exporter/blob/master/tasks/install.yml#L24-L35

Is there a specific reason this is delegated to localhost? It seems downloading and unpacking on the target node would be much better in most cases?

Then, this part:
https://github.com/cloudalchemy/ansible-node-exporter/blob/master/tasks/install.yml#L52-L60

Seems to happen almost every time. Can we add a "creates" and an initial version check? Any thoughts? I am asking because this setup seems to consume a substantial amount of time on my ansible runs and I am trying to avoid building special purpose playbooks right now and would prefer to be able to re-run this continuously/whenever with the same predicable outcome.

@paulfantom
Copy link
Member

This is a workaround for nodes which doesn't have direct access to github, for example in corporate firewalled networks.

@stale
Copy link

stale bot commented Feb 20, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Feb 20, 2019
@till
Copy link
Contributor Author

till commented Feb 20, 2019

@paulfantom thoughts on the creates? Or is this still necessary for your use-case?

@stale stale bot removed the wontfix This will not be worked on label Feb 20, 2019
@paulfantom
Copy link
Member

Version check would be a nice to have addition to this role.

@stale
Copy link

stale bot commented Apr 6, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Apr 6, 2019
@stale stale bot closed this as completed Apr 20, 2019
@lock
Copy link

lock bot commented May 20, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators May 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
wontfix This will not be worked on
Projects
None yet
2 participants