-
Notifications
You must be signed in to change notification settings - Fork 271
Optimizations #67
Comments
This is a workaround for nodes which doesn't have direct access to github, for example in corporate firewalled networks. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
@paulfantom thoughts on the creates? Or is this still necessary for your use-case? |
Version check would be a nice to have addition to this role. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
(Sorry, for lack of better headline/title...)
I had a question about this role, specifically about:
https://github.com/cloudalchemy/ansible-node-exporter/blob/master/tasks/install.yml#L24-L35
Is there a specific reason this is delegated to localhost? It seems downloading and unpacking on the target node would be much better in most cases?
Then, this part:
https://github.com/cloudalchemy/ansible-node-exporter/blob/master/tasks/install.yml#L52-L60
Seems to happen almost every time. Can we add a "creates" and an initial version check? Any thoughts? I am asking because this setup seems to consume a substantial amount of time on my ansible runs and I am trying to avoid building special purpose playbooks right now and would prefer to be able to re-run this continuously/whenever with the same predicable outcome.
The text was updated successfully, but these errors were encountered: