This repository has been archived by the owner on Mar 6, 2023. It is now read-only.
reintroduce user management into defaults and add testing user creation #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulfantom
force-pushed
the
system_user
branch
from
6dd5b1e
to
4bbded5
Compare
|
I really don't like that there's a feature in node_exporter that requires root. 😦 |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like there are use cases where node_exporter might be needed to be run as a different user than one which this role creates.
Only change in a logic is to skip user management (user and group creation) when
node_exporteris expected to be running asroot. Otherwise this just moves variables to make setting user visible and documented. Additionally I put some tests around user and group creation.Spawned by prometheus/node_exporter#1246