From 30ec98f84ec4fa65b44f668bda9b1c38fbefdcb5 Mon Sep 17 00:00:00 2001 From: Porkepix Date: Fri, 30 Mar 2018 11:41:56 +0200 Subject: [PATCH 1/4] Fix typo in a link in CONTRIBUTING.md --- CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 6b18626..fcaa503 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -45,7 +45,7 @@ We try to provide production ready ansible roles which should be as much zero-co ### Add tests -We try to have as much tests written in testinfra framework as possible, so when you copy file, some template or starting some server just add couple of lines in [/tests/test)default.py](test_default.py) file. If you want to know how to write tests in testinfra, go to their [docs](http://testinfra.readthedocs.io/en/latest/index.html). +We try to have as much tests written in testinfra framework as possible, so when you copy file, some template or starting some server just add couple of lines in [/tests/test/default.py](test_default.py) file. If you want to know how to write tests in testinfra, go to their [docs](http://testinfra.readthedocs.io/en/latest/index.html). ### Follow best practices From 618a7ef87df62f65ad57f116b0f0873f1d4dba8b Mon Sep 17 00:00:00 2001 From: Porkepix Date: Fri, 30 Mar 2018 11:42:20 +0200 Subject: [PATCH 2/4] Remove Go compiler requirement from README --- README.md | 1 - 1 file changed, 1 deletion(-) diff --git a/README.md b/README.md index 6b240ab..b590335 100644 --- a/README.md +++ b/README.md @@ -15,7 +15,6 @@ Deploy prometheus [node exporter](https://github.com/prometheus/node_exporter) u ## Requirements - Ansible >= 2.3 -- go-lang installed on deployer machine (same one where ansible is installed) ## Role Variables From 48edd906272b122fd5dd76d656aa4c2d7c619da5 Mon Sep 17 00:00:00 2001 From: Porkepix Date: Fri, 30 Mar 2018 11:43:51 +0200 Subject: [PATCH 3/4] Skip binary propagation in check_mode This will result in a playbook fail otherwise --- tasks/main.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/tasks/main.yml b/tasks/main.yml index 3d918b8..66a0015 100644 --- a/tasks/main.yml +++ b/tasks/main.yml @@ -35,6 +35,7 @@ group: "node-exp" notify: - restart node exporter + when: not ansible_check_mode - name: Install libcap on Debian systems package: From 7f5ac161e2508e01233a60954cc68fb9eb3b7a16 Mon Sep 17 00:00:00 2001 From: Porkepix Date: Fri, 30 Mar 2018 11:56:14 +0200 Subject: [PATCH 4/4] Fix the typo made by fixing a typo in CONTRIBUTING --- CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index fcaa503..3ff2830 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -45,7 +45,7 @@ We try to provide production ready ansible roles which should be as much zero-co ### Add tests -We try to have as much tests written in testinfra framework as possible, so when you copy file, some template or starting some server just add couple of lines in [/tests/test/default.py](test_default.py) file. If you want to know how to write tests in testinfra, go to their [docs](http://testinfra.readthedocs.io/en/latest/index.html). +We try to have as much tests written in testinfra framework as possible, so when you copy file, some template or starting some server just add couple of lines in [/tests/test_default.py](test_default.py) file. If you want to know how to write tests in testinfra, go to their [docs](http://testinfra.readthedocs.io/en/latest/index.html). ### Follow best practices