Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ClickOps S3 Bucket Actions Not Picked Up by UserAgent #99

Open
MXGong opened this issue Nov 19, 2024 · 0 comments
Open

ClickOps S3 Bucket Actions Not Picked Up by UserAgent #99

MXGong opened this issue Nov 19, 2024 · 0 comments

Comments

@MXGong
Copy link

MXGong commented Nov 19, 2024

Issue:
When clickops action for S3 Buckets (Create/Delete, Update Policy/Settings), the action was not picked up, and no notification was sent.

Cause:
The userAgent shows in payload for s3bucket clickops action:

 "eventName": "CreateBucket",
  "awsRegion": "<region>",
  "sourceIPAddress": "<ip>",
  "userAgent": "[Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/130.0.0.0 Safari/537.36]",

The current self.USER_AGENT_RE (clickops.py) has "^Mozilla/", it doesn't cover starting with "["

Fix:
Add the following in the list self.USER_AGENTS_RE (clickops.py), it works

            "^Mozilla/",
            "^\[Mozilla/", 

PS: Tried to raise Pull request, but got access denied on push.

@MXGong MXGong changed the title ClickOps S3 Bucket Actions Not Detected by UserAgent ClickOps S3 Bucket Actions Not Picked Up by UserAgent Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant