Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CloudEvents prefix for extension attributes in Kafka headers #93

Closed
pdalbora opened this issue Feb 5, 2020 · 3 comments
Closed

CloudEvents prefix for extension attributes in Kafka headers #93

pdalbora opened this issue Feb 5, 2020 · 3 comments
Labels
good first issue Good for newcomers

Comments

@pdalbora
Copy link

pdalbora commented Feb 5, 2020

The Java SDK does not currently prefix extension attributes with "ce_" in the headers.

Section 3.2.3.1 of the specification for Kafka Protocol Binding states that "CloudEvent attributes are prefixed with ce_ for use in the message-headers section." While the specification does not explicitly state either way whether this applies also to extension attributes, I can't see a good reason why they would be treated differently.

Is the different treatment of extension attributes in the SDK intentional, or do you agree that they should also be prefixed with "ce_"?

@fabiojose fabiojose added the good first issue Good for newcomers label Feb 13, 2020
@fabiojose
Copy link
Contributor

We aggree @pdalbora, they must be prefixed.

@bsideup
Copy link
Contributor

bsideup commented Feb 13, 2020

Is there some soft of a TCK for the spec?

@slinkydeveloper
Copy link
Member

I think this one should work with 2.0.0-SNAPSHOT, reopen if you need it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants