Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PI-1056 fixed active zone selector not clickable bug #114

Merged
merged 2 commits into from
Mar 31, 2017

Conversation

thellimist
Copy link
Contributor

After the first zone switch, the div was being rendered below other divs so it wasn't recognizing the click. I did a quick z-index. The whole active zone selector CSS is a mess. We may need to fix it at some point

@@ -57,7 +57,8 @@ class ActiveZoneSelector extends Component {
top: '50%',
transform: 'translateY(-50%)',
width: '200px',
marginLeft: '170px'
marginLeft: '170px',
zIndex: '1'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugh, I hate this but I don't have a better solution. Which integration is this for?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This only happens in multi zoned integrations but I added to general because why not. The solution is already a mess. Tested on WordPress and works fine

@thellimist
Copy link
Contributor Author

screen shot 2017-03-30 at 16 58 06

I figured the exact reason of the bug. Under attack button is too long. Fixing the whole CSS would also fix this issue

@jwineman
Copy link
Contributor

Can we do that instead? z-index is basically just tech debt. No reason the under attack button needs all that space. These styles can (should?) still live inline though since it will apply to all integrations right?

@thellimist
Copy link
Contributor Author

Yes, I'll try to fix the CSS of the whole bar.

@thellimist
Copy link
Contributor Author

thellimist commented Mar 31, 2017

Tested on CPanel and WordPress. Will add WordPress commit hacks.css as well.

The problem was earlier I had put position: absolute inline which messed up everything. Converting them to position: relative fixed the issue.

After fixing that WordPress was fine but CPanel messed up. Changing top: '50%', to top: '30px', fixed CPanel. I didn't get why in CPanel the div didn't get it's parent % while in WordPress it did though.

CSS is weird, Integrations are weirder...

@thellimist
Copy link
Contributor Author

thellimist commented Mar 31, 2017

Currently the only issue is long domain names are kind of hidden

screen shot 2017-03-31 at 16 45 46

The average domain name length is 14 characters. The average looks OK

screen shot 2017-03-31 at 16 49 06

@jwineman
Copy link
Contributor

thats okay

@jwineman
Copy link
Contributor

LGTM

@thellimist thellimist merged commit baf2713 into master Mar 31, 2017
@thellimist
Copy link
Contributor Author

You can approve an approved PR. No need for LGTM anymore 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants