-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PI-1056 fixed active zone selector not clickable bug #114
Conversation
@@ -57,7 +57,8 @@ class ActiveZoneSelector extends Component { | |||
top: '50%', | |||
transform: 'translateY(-50%)', | |||
width: '200px', | |||
marginLeft: '170px' | |||
marginLeft: '170px', | |||
zIndex: '1' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ugh, I hate this but I don't have a better solution. Which integration is this for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This only happens in multi zoned integrations but I added to general because why not. The solution is already a mess. Tested on WordPress and works fine
Can we do that instead? |
Yes, I'll try to fix the CSS of the whole bar. |
Tested on CPanel and WordPress. Will add WordPress commit hacks.css as well. The problem was earlier I had put After fixing that WordPress was fine but CPanel messed up. Changing CSS is weird, Integrations are weirder... |
thats okay |
LGTM |
You can approve an approved PR. No need for LGTM anymore 😄 |
After the first zone switch, the div was being rendered below other divs so it wasn't recognizing the click. I did a quick
z-index
. The whole active zone selector CSS is a mess. We may need to fix it at some point