PI-1066 fixed bug with minify card #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah I want to avoid updating cf-ui components until the fela migration is complete. |
|
I bet this bug was introduced at the same time the |
jwineman
approved these changes
Apr 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
itemdoes not havevalueattribute. It's just a string.We've update cf-component-checkbox to 3.0.1 a month ago. But I've checked whether it was a bug caused by us or cf-ui. It seems like cf-ui update did not cause the bug. More interestingly this part of code has not been changed for 11 months. I remember testing every future before WP launch. So I've no idea how we introduced this bug. Also no one actually noticed it for a year...
Currently cf-ui is doing lots of updates. I'm happy with the current version so I choose not to update cf-component-checkbox to 3.2.0 which is the newest version.