Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Guzzle in favor of WordPress core functions #446

Merged
merged 3 commits into from
Mar 7, 2022

Conversation

ethanclevenger91
Copy link
Contributor

@ethanclevenger91 ethanclevenger91 commented Nov 11, 2021

Closes #445

This PR is probably incomplete. A couple notes:

  • Moves away from Guzzle exception classes. Replaced with what I considered sensible alternatives, but this will alter the logs that result from failed requests
  • Inexperienced with stubbing WordPress core functions, so you may desire more comprehensive testing
  • Docker image wouldn't build w/o adding an argument to apt-get update

But that said, all tests pass and I'll be giving this a go on a staging client site.

@ethanclevenger91
Copy link
Contributor Author

Oof, yeah, looking at the commit history, looks like some of this logic is part of some alternative centralized bunch of code that gets split between all your various plugins, so this probably isn't going to work super well from a workflow perspective, though it seems to be working fine standalone.

@jacobbednarz
Copy link
Member

Thanks for this @ethanclevenger91! Luckily, I had combined cloudflare-backend not too long ago, so there aren't any additional plugins that rely on this now. The frontend is still separate however, there are some plans in the works to clear that up as well once we find some time for it.

Testing this locally looks pretty good to me and I can't stop anything that is out of what we would expect (even with exceptions). I'm happy to land this and if anything else pops up from it, we just address it in an upcoming release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4.7.0 Guzzle dependency breaks sites using different versions
2 participants