From 6f10f22d398ed8a9273d0344abe6b7e20e444252 Mon Sep 17 00:00:00 2001 From: Gabor Tanz Date: Sun, 24 Nov 2019 13:19:32 +0100 Subject: [PATCH 1/2] also output sha256 digest when generating certificate --- api/generator/generator.go | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/api/generator/generator.go b/api/generator/generator.go index c958f610d..6e6fba57c 100644 --- a/api/generator/generator.go +++ b/api/generator/generator.go @@ -4,6 +4,7 @@ package generator import ( "crypto/md5" "crypto/sha1" + "crypto/sha256" "crypto/x509" "encoding/json" "encoding/pem" @@ -35,6 +36,7 @@ specifically, section 10.2.3 ("Information Requirements").` type Sum struct { MD5 string `json:"md5"` SHA1 string `json:"sha-1"` + SHA256 string `json:"sha-256"` } // Validator is a type of function that contains the logic for validating @@ -97,8 +99,10 @@ func computeSum(in []byte) (sum Sum, err error) { md5Sum := md5.Sum(data) sha1Sum := sha1.Sum(data) + sha256Sum := sha256.Sum256(data) sum.MD5 = fmt.Sprintf("%X", md5Sum[:]) sum.SHA1 = fmt.Sprintf("%X", sha1Sum[:]) + sum.SHA256 = fmt.Sprintf("%X", sha256Sum[:]) return } From b41fd33b31f6d8620e76ce94563d77e6cae513db Mon Sep 17 00:00:00 2001 From: Gabor Tanz Date: Sun, 24 Nov 2019 13:43:37 +0100 Subject: [PATCH 2/2] update documentation with sha256 hashes --- doc/api/endpoint_newcert.txt | 6 ++++-- doc/api/endpoint_newkey.txt | 3 ++- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/doc/api/endpoint_newcert.txt b/doc/api/endpoint_newcert.txt index c4ecb5408..3cde9b6a2 100644 --- a/doc/api/endpoint_newcert.txt +++ b/doc/api/endpoint_newcert.txt @@ -50,11 +50,13 @@ Example: "sums": { "certificate": { "md5": "E9308D1892F1B77E6721EA2F79C026BE", - "sha-1": "4640E6DEC2C40B74F46C409C1D31928EE0073D25" + "sha-1": "4640E6DEC2C40B74F46C409C1D31928EE0073D25", + "sha-256": "8812010B59EB8C00CDD9292078717216B131A710703F18A4DFB94AC166F507DF" }, "certificate_request": { "md5": "AA924136405006E36CEE39FED9CBA5D7", - "sha-1": "DF955A43DF669D38E07BF0479789D13881DC9024" + "sha-1": "DF955A43DF669D38E07BF0479789D13881DC9024", + "sha-256": "C7600A68BDB689346E2E4438A374606DFC3FFD3B6B9722E0A8CB32AA88FBA686" } } }, diff --git a/doc/api/endpoint_newkey.txt b/doc/api/endpoint_newkey.txt index 7256dd130..069129ee0 100644 --- a/doc/api/endpoint_newkey.txt +++ b/doc/api/endpoint_newkey.txt @@ -46,7 +46,8 @@ Example: "sums": { "certificate_request": { "md5": "95E25336DA65B58DA250C3B5FAA4B97F", - "sha-1": "5F1ACE9D14F55E95FAA246A80474873C14E0F42F" + "sha-1": "5F1ACE9D14F55E95FAA246A80474873C14E0F42F", + "sha-256": "EA8409AE9117FE62A91DBD64F2C7496DC4CF3A06C5D513D5811A1CC1E8B2D180" } } },