Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align on purego build tag. #491

Closed
mattyclarkson opened this issue Mar 22, 2024 · 1 comment · Fixed by #492
Closed

Align on purego build tag. #491

mattyclarkson opened this issue Mar 22, 2024 · 1 comment · Fixed by #492
Labels
cosmetic readability an cleanliness of code help wanted Extra attention is needed

Comments

@mattyclarkson
Copy link
Contributor

golang/go#23172 proposes the de-facto purego build tag.

circl uses both purego and noasm build tags, inconsistently.

If a user wants a purego build, the build should not include assembly.

Would circl be willing to align on purego meaning noasm?

For example, this is what the upstream golang crypto package does: https://go-review.googlesource.com/c/go/+/561935

Another option is to make purego and noasm equivalent in the code-base if noasm needs to be a backwards supported build flag.

I would be willing to contribute the patch.

@armfazh
Copy link
Contributor

armfazh commented Mar 22, 2024

@mattyclarkson thanks for raising this issue, happy to review your patch.

@armfazh armfazh added help wanted Extra attention is needed cosmetic readability an cleanliness of code labels Mar 22, 2024
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cosmetic readability an cleanliness of code help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants