Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ACVP test "sigVer" is not used in #480 #516

Closed
UladzimirTrehubenka opened this issue Oct 9, 2024 · 1 comment · Fixed by #517
Closed

ACVP test "sigVer" is not used in #480 #516

UladzimirTrehubenka opened this issue Oct 9, 2024 · 1 comment · Fixed by #517

Comments

@UladzimirTrehubenka
Copy link

Observed after merge #480:
https://github.com/cloudflare/circl/blob/main/sign/mldsa/mldsa87/acvp_test.go#L48
has "keyGen" and "sigGen" but not "sigVer" (implemented already). However "sigVer" after enable won't work because need to implement a function similar to unsafeSignInternal() like unsafeVerifyInternal(), because exported Verify() uses ctx (empty), but two bytes with zero values are added before verified message anyway.
@armfazh armfazh mentioned this issue Oct 9, 2024
Merged
@bwesterb
Copy link
Member

Whoops! Thanks for reporting. @armfazh solved it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

sign/mldsa: Add test for ML-DSA signature verification. armfazh/circl
2 participants
@bwesterb @UladzimirTrehubenka