-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PI-1033 more under stable message to users #115
Conversation
lang/en.js
Outdated
@@ -230,7 +230,7 @@ | |||
"constants.plans.pro": "Pro plan", | |||
"constants.plans.biz": "Business plan", | |||
"constants.plans.ent": "Enterprise plan", | |||
"errors.noActiveZoneSelected": "Please select a domain that is provisioned with Cloudflare.", | |||
"errors.noActiveZoneSelected": "Please continue to {link} to set up this domain.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we update this to:
It looks like {domain} isn't provisioned with Cloudflare. Please continue to {link} to provision this domain.
This should help us debug the WordPress issues where they have a subdomain or a folder.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And we need a conditional for cPanel which links them to the domains page since those domains are provisoned in app.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isDNSPageEnabled(config)
link to the DNSPage instead of add site link
@@ -49,6 +51,10 @@ class WaitForSettings extends Component { | |||
isPluginSettingsLoaded && | |||
isAnalyticsLoaded; | |||
|
|||
let link = ( | |||
<a href={CLOUDFLARE_ADD_SITE_PAGE} target="_blank">Cloudflare</a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{ isDNSPageEnabled(config) ? DNS_PAGE : CLOUDFLARE_ADD_SITE_PAGE }
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ohh nice idea.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Took longer than expected :/
40db1bd
<FormattedMessage id="errors.noActiveZoneSelected" /> | ||
<FormattedMessage | ||
id="errors.noActiveZoneSelected" | ||
values={{ link: link, domain: activeZone.name }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to add domain
here too.
EDIT: NVM Im very dumb
<FormattedMessage id="container.dnsManagementPage.title" /> | ||
</Link> | ||
); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to do inline if case thing but prettier was complaining and couldn't figure out why. Then did this instead of ignore-prettier
Updated the text again per request from GG |
No description provided.