Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Splash page #131

Merged
merged 11 commits into from
Jun 28, 2017
Merged

Splash page #131

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
262110a
Adde new splash page
manatarms Jun 20, 2017
dfa5621
Yarn upgrade and new eslint rules
manatarms Jun 20, 2017
07693c2
Fixed eslint errors
manatarms Jun 20, 2017
9c0d829
Changed route names to better names
manatarms Jun 20, 2017
1d3b770
Changed the channel values and added more tests for channel function
manatarms Jun 20, 2017
2435ab7
Added integration specific heading
manatarms Jun 22, 2017
60d061b
Updated tests for channel generator
manatarms Jun 22, 2017
21b41b3
Fix conflict
manatarms Jun 27, 2017
2e16701
Changed to svgs
manatarms Jun 27, 2017
321aa21
Updated tests
manatarms Jun 27, 2017
63f740d
Merge branch 'master' into splash-page
manatarms Jun 28, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lang/en.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

17 changes: 13 additions & 4 deletions src/containers/SplashPage/SplashPage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,16 +59,20 @@ class SplashPage extends Component {
render() {
const { config } = this.props;

const integrationName = getConfigValue(config, 'integrationName');
const integrationNameCapital =
integrationName.charAt(0).toUpperCase() + integrationName.slice(1);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a small detail but this will produce Wordpress rather than WordPress. Check if Garrett is OK with it.


let signupLinkWithUTM = generateUTMLink(
CLOUDFLARE_SIGNUP_PAGE,
getConfigValue(config, 'integrationName'),
getConfigValue(config, 'integrationName'),
integrationName,
integrationName,
SIGNUP_SPLASH_UTM_CONTENT_IDENTIFIER
);

let signupLinkWithUTMAndChannel = generateChannelLink(
signupLinkWithUTM,
getConfigValue(config, 'integrationName')
integrationName
);

return (
Expand All @@ -80,7 +84,12 @@ class SplashPage extends Component {
<LayoutRow>
<LayoutColumn width={1 / 1}>
<Heading size={1}>
<FormattedMessage id="container.splashPage.heading.speedUp" />
<FormattedMessage
id="container.splashPage.heading.speedUp"
values={{
integrationName: integrationNameCapital
}}
/>
</Heading>
</LayoutColumn>
</LayoutRow>
Expand Down