Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gotchas documentation #599

Merged
merged 5 commits into from
Dec 22, 2023
Merged

Conversation

dario-piotrowicz
Copy link
Member

resolves #598

Copy link

changeset-bot bot commented Dec 18, 2023

⚠️ No Changeset found

Latest commit: 3d461a8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Dec 18, 2023

🧪 Prereleases are available for testing 🧪

@cloudflare/next-on-pages

You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/next-on-pages/runs/7302485479/npm-package-next-on-pages-599

@cloudflare/eslint-plugin-next-on-pages

You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/next-on-pages/runs/7302485479/npm-package-eslint-plugin-next-on-pages-599

@sanketnaik99
Copy link

@dario-piotrowicz Hey! I've been trying to implement dynamic routes for my Next.js pages project using the app router but my builds keep failing on Cloudflare.

When I try to use the edge runtime I get a segmentation fault.

Should it be possible to use dynamic routes if I use the edge runtime or is that not supported on Cloudflare at all?

@dario-piotrowicz
Copy link
Member Author

Hi @sanketnaik99, yeah dynamic routes should be supported with no issues

I am not sure what problem you're facing, please open a new issue regarding that and we can discuss further there 🙂
(please try to provide a minimal reproduction as that does help massively 🙏)


PS: some people have had issues building their next-on-pages applications using the Pages git integration and they have had segfaults caused by the next build process (we haven't been able to look into it as we lack code to reproduce the issue), if that's your case please also try to deploy the application manually using wrangler pages deploy .vercel/output/static.

@sanketnaik99
Copy link

@dario-piotrowicz Thanks! Yeah, it has something to do with my application because it's a huge codebase and I'm migrating it from pages to app router. I'll keep digging into it, but I got dynamic routes to work in a smaller application.

Once again, thanks for your quick reply!

@dario-piotrowicz
Copy link
Member Author

@sanketnaik99 not a problem 🙂

yes, please keep digging into it and feel free to open an issue whenever you want if you get stuck as we are always keen to help 😄

Although if you have a big app and cannot share its code there might be little we can do to help 😓

@dario-piotrowicz dario-piotrowicz merged commit 2b5c8f2 into cloudflare:main Dec 22, 2023
8 checks passed
@dario-piotrowicz dario-piotrowicz deleted the gotchas branch December 22, 2023 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: Using headers or cookies in the root layout fail the build
3 participants