Option to install the OriginIssuer CRD automatically with the Helm chart

[itay-grudev]

Can we add an option to install the OriginIssuer CRD automatically with the Helm chart?

It can be done with a custom option like cert-manager's installCRDs option? It could be false by default for backwards compatibility (like cert-manager).

It would just require one manual step less and would allow to install this as a subchart. (See #77).

Are PRs accepted for this change?

[itay-grudev]

@terinjokes

[terinjokes]

It is recommended by Helm documentation to not install CRDs as part of a chart.

[itay-grudev]

Since when? It has special support for CRDs.

https://helm.sh/docs/chart_best_practices/custom_resource_definitions/

[itay-grudev]

This would allow initializing our entire cluster automatically with a single helm chart and a bunch of subcharts as dependencies. I would really like to build that, but there are a few blockers and I am submitting PRs on my holiday to achieve my dream.

[itay-grudev]

It also creates a really clean GitOps management where everything is in Helm charts only without additional manual interaction.

[itay-grudev]

I think this also answers your question in #77, but I'll copy it over for posterity.

[terinjokes]

There is no support at this time for upgrading or deleting CRDs using Helm.

[itay-grudev]

It doesn't hurt installing them though. Saves an extra step on initial setup and doesn't do anything about upgrading as expected.

[itay-grudev]

Just to reinforce my point here: cert-manager works like that via the --set installCRDs=true flag.

[terinjokes]

Reopening this to investigate the Helm 3 behavior.

[sebanzer]

https://helm.sh/docs/chart_best_practices/custom_resource_definitions/

helm docs state let helm do it or create a separate chart including only the CRD's

helm automatically install's crds provided in the crds directory of a chart but those are then not templated and always installed unless --skip-crds is provided.

one can also add the CRD's to the templates directory and do a if and check for global.crds.create, like you do on global.rbac.create which you can default to false.

[terinjokes]

@sebanzer the previous discussion was about a previous version of the docs, I reopened it in light of the new recommendations.

[stucki-stuck]

any updates ?

[terinjokes]

Still waiting for a conclusion in cert-manager/cert-manager#6179