-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option to install the OriginIssuer CRD automatically with the Helm chart #78
Comments
It is recommended by Helm documentation to not install CRDs as part of a chart. |
Since when? It has special support for CRDs. https://helm.sh/docs/chart_best_practices/custom_resource_definitions/ |
This would allow initializing our entire cluster automatically with a single helm chart and a bunch of subcharts as dependencies. I would really like to build that, but there are a few blockers and I am submitting PRs on my holiday to achieve my dream. |
It also creates a really clean GitOps management where everything is in Helm charts only without additional manual interaction. |
I think this also answers your question in #77, but I'll copy it over for posterity. |
|
It doesn't hurt installing them though. Saves an extra step on initial setup and doesn't do anything about upgrading as expected. |
Just to reinforce my point here: |
Reopening this to investigate the Helm 3 behavior. |
https://helm.sh/docs/chart_best_practices/custom_resource_definitions/ helm docs state let helm do it or create a separate chart including only the CRD's helm automatically install's crds provided in the one can also add the CRD's to the templates directory and do a if and check for |
@sebanzer the previous discussion was about a previous version of the docs, I reopened it in light of the new recommendations. |
any updates ? |
Still waiting for a conclusion in cert-manager/cert-manager#6179 |
Can we add an option to install the OriginIssuer CRD automatically with the Helm chart?
It can be done with a custom option like
cert-manager
'sinstallCRDs
option? It could befalse
by default for backwards compatibility (likecert-manager
).It would just require one manual step less and would allow to install this as a subchart. (See #77).
Are PRs accepted for this change?
The text was updated successfully, but these errors were encountered: