Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ› Bug Report β€” console.log() behaviour changed, possibly unintentionally? #1344

Closed
0xakihiko opened this issue Oct 25, 2023 · 4 comments

Comments

@0xakihiko
Copy link
Contributor

Starting with version v1.20231023.0.

I noticed in #1294 that the console behavior had changed.

OS
This is on macOS, and I have not tested the behavior yet on Linux.

Description
Previously, when I did a console.log it would show up in stderr (explicitly mentioning that this did NOT output to stdout to avoid confusion).

Now, when I do a console.log, it does not show up at all, even with --verbose flag, and does not show up in stdout at all.

If I change this to console.error, it will show up in the stderr as it did before.

Questions for debug
Is this intended behaviour? If it should be showing up in stdout, let me know and I'll debug on my side as my usage of workerd could be the issue in this case as I do have an "odd" way to run workerd.

Should it now be showing up in stdout, or is there a different way intended way to handle logs now?

@mrbbot
Copy link
Contributor

mrbbot commented Oct 25, 2023

Hey! πŸ‘‹ There were a few issues with #1294 that have been fixed in #1343. We're going to do another release today, that hopefully will resolve the issues you're seeing.

@0xakihiko
Copy link
Contributor Author

Yep, I had a feeling it could be this.

I was going to update this ticket if it did fix the issue once that version with your fix is done building on my fork but I guess you beat me to it.

@mrbbot
Copy link
Contributor

mrbbot commented Oct 25, 2023

Hey! workerd@1.20231025.0 has just been released which should hopefully fix this. Please let me know if this works. πŸ‘

@0xakihiko
Copy link
Contributor Author

0xakihiko commented Oct 25, 2023

Hey! workerd@1.20231025.0 has just been released which should hopefully fix this. Please let me know if this works. πŸ‘

Happy to report it worked πŸŽ‰, I'm also very happy to report I'm no longer seeing a dreaded [object Object] but the actual objects contents.

AND...the output is now to stdout! No more stderr parsing for what is a log or error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants