Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ› Bug Report β€” Runtime APIs #2540

Closed
tpasternak opened this issue Aug 16, 2024 · 2 comments Β· Fixed by #2522
Closed

πŸ› Bug Report β€” Runtime APIs #2540

tpasternak opened this issue Aug 16, 2024 · 2 comments Β· Fixed by #2522

Comments

@tpasternak
Copy link

Hey workerd team!

I've just been trying to open the codebase with CLion on Fedora 40, and it looks like the default clang version can't build zlib with the default opts.

It looks like you have to add either -Wno-error=register or --std=c++14 here

workerd/WORKSPACE

Lines 291 to 293 in 7aa2d5f

copts = [
"-w",
"-Dverbose=-1",

@fhanau
Copy link
Collaborator

fhanau commented Aug 18, 2024

What clang version number are you using and does clang on Fedora add additional options such as -Werror? Any version 16+ should work, with clang-18 I'm not getting any warnings for it locally. Note that zlib is exclusively C, so there should be no need to specify C++14 here.

@npaun npaun mentioned this issue Aug 19, 2024
@npaun npaun linked a pull request Aug 19, 2024 that will close this issue
@tpasternak
Copy link
Author

nvm I accidentally set --action_env=CC=clang++

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants
@tpasternak @fhanau and others