Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C3: Improve @cloudflare/workers-types types used for Workers #4514

Closed
dario-piotrowicz opened this issue Nov 27, 2023 · 1 comment · Fixed by #4525
Closed

C3: Improve @cloudflare/workers-types types used for Workers #4514

dario-piotrowicz opened this issue Nov 27, 2023 · 1 comment · Fixed by #4525
Assignees
Labels
c3 Relating to C3 (create-cloudflare) package

Comments

@dario-piotrowicz
Copy link
Member

dario-piotrowicz commented Nov 27, 2023

Describe the solution

In C3 when creating a new worker we get the latest compatibility date and apply it to the worker's toml file (source) the @cloudflare/workers-types types used do not however match such compatibility date (see comment) causing a confusing and frustrating experience for developers.

So we should also:

This should provide a valid setup for developers and allow them to proceed with their work without type issues.

Note

it is still confusing that there is a compatibility date and a (most likely) different workers-types entrpoint date, that is however an issue that needs to be solved separately and not something that we can address in C3, hopefully this will be addressed in the future making the use of types more straightforward for developers

@dario-piotrowicz dario-piotrowicz added the c3 Relating to C3 (create-cloudflare) package label Nov 27, 2023
@Cherry
Copy link
Contributor

Cherry commented Nov 27, 2023

This sounds like a great improvement, thanks Dario! Excited to see this land.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c3 Relating to C3 (create-cloudflare) package
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants