Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 BUG: C3 2.8.2 always initialises JavaScript, even when TypeScript is selected #4599

Closed
Cherry opened this issue Dec 13, 2023 · 2 comments · Fixed by #4598
Closed

🐛 BUG: C3 2.8.2 always initialises JavaScript, even when TypeScript is selected #4599

Cherry opened this issue Dec 13, 2023 · 2 comments · Fixed by #4598
Assignees
Labels
bug Something that isn't working

Comments

@Cherry
Copy link
Contributor

Cherry commented Dec 13, 2023

Which Cloudflare product(s) does this pertain to?

C3

What version(s) of the tool(s) are you using?

C3 2.8.2

What version of Node are you using?

20.10.0

What operating system are you using?

Windows 11

Describe the Bug

c3 2.8.1

  • npm create cloudflare@2.8.1 -- --no-auto-update
  • use all defaults - ensure you say "yes" to TypeScript
  • you'll get a TypeScript project, with src/index.ts

c3 2.8.2

  • npm create cloudflare@2.8.2 -- --no-auto-update
  • use all defaults - ensure you say "yes" to TypeScript
  • you'll get a JavaScript project, no types, src/index.js

It seems this regression was introduced in #4470 and unfortunately wasn't caught in any automated testing. It also took longer than I care to admit to find that PR, without a changeset 😅

@Cherry Cherry added the bug Something that isn't working label Dec 13, 2023
@samaritanau
Copy link

I can confirm!

@Skye-31 Skye-31 mentioned this issue Dec 13, 2023
6 tasks
@rita3ko
Copy link

rita3ko commented Dec 15, 2023

I also ran into this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something that isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants