Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 BUG: getPlatformProxy DO proxy "undefined" is not a valid JSON #5620

Closed
dario-piotrowicz opened this issue Apr 15, 2024 · 3 comments · Fixed by #5669
Closed

🐛 BUG: getPlatformProxy DO proxy "undefined" is not a valid JSON #5620

dario-piotrowicz opened this issue Apr 15, 2024 · 3 comments · Fixed by #5669
Assignees
Labels
bug Something that isn't working regression Break in existing functionality as a result of a recent change wrangler Relating to the Wrangler CLI tool

Comments

@dario-piotrowicz
Copy link
Member

dario-piotrowicz commented Apr 15, 2024

Which Cloudflare product(s) does this pertain to?

Wrangler core

What version(s) of the tool(s) are you using?

wrangler@3.50.0

What version of Node are you using?

20

What operating system and version are you using?

Mac

Observed behavior

When using getPlatformProxy with recent version of wrangler (v>=3.46.0) it seems like DurableObject proxies don't properly work and when trying to fetch from them an response saying that undefined is not a valid JSON value is presented:
ko

Expected behavior

Fetching from a DurableObject proxy should work as expected (as it worked with wrangler versions <= 3.45.0):
ok

Minimal reproduction

https://github.com/dario-piotrowicz/getPlatformProxy-DO-JSON-issue-repro

@dario-piotrowicz dario-piotrowicz added the bug Something that isn't working label Apr 15, 2024
@github-project-automation github-project-automation bot moved this to Untriaged in workers-sdk Apr 15, 2024
@dario-piotrowicz dario-piotrowicz added regression Break in existing functionality as a result of a recent change wrangler Relating to the Wrangler CLI tool labels Apr 15, 2024
@dario-piotrowicz dario-piotrowicz self-assigned this Apr 15, 2024
@dario-piotrowicz dario-piotrowicz changed the title 🐛 BUG: getPlatformProxy DO proxy undefined not a valid JSON issue 🐛 BUG: getPlatformProxy DO proxy "undefined" not a valid JSON issue Apr 15, 2024
@dario-piotrowicz dario-piotrowicz changed the title 🐛 BUG: getPlatformProxy DO proxy "undefined" not a valid JSON issue 🐛 BUG: getPlatformProxy DO proxy "undefined" is not a valid JSON Apr 15, 2024
@dario-piotrowicz
Copy link
Member Author

Ok, this issue explains this 🥲: #5599 (comment)
(and that's also why we were unable to prevent this regression from happening)

@clibequilibrium
Copy link

Ok, this issue explains this 🥲: #5599 (comment) (and that's also why we were unable to prevent this regression from happening)

Thank you for this ! Same issue here on latest wrangler, we are forced to use downgraded version for now

@dario-piotrowicz
Copy link
Member Author

@clibequilibrium the fix is on it's way in #5669 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something that isn't working regression Break in existing functionality as a result of a recent change wrangler Relating to the Wrangler CLI tool
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants