-
Notifications
You must be signed in to change notification settings - Fork 724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ensure logged in when choosing account during pre-existing worker C3 flow #7034
Conversation
…ring pre-existing Worker C3 flow
🦋 Changeset detectedLatest commit: 28e1c10 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11457033269/npm-package-wrangler-7034 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7034/npm-package-wrangler-7034 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11457033269/npm-package-wrangler-7034 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11457033269/npm-package-create-cloudflare-7034 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11457033269/npm-package-cloudflare-kv-asset-handler-7034 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11457033269/npm-package-miniflare-7034 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11457033269/npm-package-cloudflare-pages-shared-7034 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11457033269/npm-package-cloudflare-vitest-pool-workers-7034 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11457033269/npm-package-cloudflare-workers-editor-shared-7034 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11457033269/npm-package-cloudflare-workers-shared-7034 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ ed pending some tests
What this PR solves / how to test
Fixes #000.
This addresses errors that we received via telemetry:
When creating a worker with C3 from a pre-existing worker, it assumed that you were logged in, but didn't actually check that. This change ensures that the user is logged in before trying to choose the account.
Author has addressed the following