Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure logged in when choosing account during pre-existing worker C3 flow #7034

Merged
merged 4 commits into from
Oct 22, 2024

Conversation

andyjessop
Copy link
Contributor

@andyjessop andyjessop commented Oct 21, 2024

What this PR solves / how to test

Fixes #000.

This addresses errors that we received via telemetry:

c3: Unable to find any accounts to deploy to! Please ensure you're logged in as a user that can deploy Workers.

When creating a worker with C3 from a pre-existing worker, it assumed that you were logged in, but didn't actually check that. This change ensures that the user is logged in before trying to choose the account.

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because:
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Changeset included
    • Changeset not necessary because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: bug fix

@andyjessop andyjessop requested review from a team as code owners October 21, 2024 09:11
Copy link

changeset-bot bot commented Oct 21, 2024

🦋 Changeset detected

Latest commit: 28e1c10

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-cloudflare Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Oct 21, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11457033269/npm-package-wrangler-7034

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7034/npm-package-wrangler-7034

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11457033269/npm-package-wrangler-7034 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11457033269/npm-package-create-cloudflare-7034 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11457033269/npm-package-cloudflare-kv-asset-handler-7034
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11457033269/npm-package-miniflare-7034
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11457033269/npm-package-cloudflare-pages-shared-7034
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11457033269/npm-package-cloudflare-vitest-pool-workers-7034
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11457033269/npm-package-cloudflare-workers-editor-shared-7034
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11457033269/npm-package-cloudflare-workers-shared-7034

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.81.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241011.0
workerd 1.20241018.1 1.20241018.1
workerd --version 1.20241018.1 2024-10-18

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@andyjessop andyjessop added the e2e Run e2e tests on a PR label Oct 21, 2024
Copy link
Contributor

@CarmenPopoviciu CarmenPopoviciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ ed pending some tests

@andyjessop andyjessop merged commit 0e91d42 into main Oct 22, 2024
29 of 31 checks passed
@andyjessop andyjessop deleted the aj/choose-account-error-fix branch October 22, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run e2e tests on a PR
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants