Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wrangler): Show wrangler pages dev --proxy warning #7041

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

CarmenPopoviciu
Copy link
Contributor

@CarmenPopoviciu CarmenPopoviciu commented Oct 21, 2024

On Node.js 17+, wrangler will default to fetching only the IPv6 address. With these changes we warn users that the process listening on the port specified via --proxy should be configured for IPv6.

Fixes #2244.


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: covered by fixture tests
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: simply adds a warning message

@CarmenPopoviciu CarmenPopoviciu requested review from a team as code owners October 21, 2024 15:03
Copy link

changeset-bot bot commented Oct 21, 2024

🦋 Changeset detected

Latest commit: c92701a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Oct 21, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11444449572/npm-package-wrangler-7041

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7041/npm-package-wrangler-7041

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11444449572/npm-package-wrangler-7041 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11444449572/npm-package-create-cloudflare-7041 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11444449572/npm-package-cloudflare-kv-asset-handler-7041
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11444449572/npm-package-miniflare-7041
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11444449572/npm-package-cloudflare-pages-shared-7041
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11444449572/npm-package-cloudflare-vitest-pool-workers-7041
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11444449572/npm-package-cloudflare-workers-editor-shared-7041
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11444449572/npm-package-cloudflare-workers-shared-7041

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.81.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241011.0
workerd 1.20241018.1 1.20241018.1
workerd --version 1.20241018.1 2024-10-18

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@CarmenPopoviciu CarmenPopoviciu added the skip-pr-description-validation Skip validation of the required PR description format label Oct 21, 2024
On Node.js 17+, wrangler will default to fetching only
the IPv6 address. With these changes we warn users that
the process listening on the port specified via `--proxy`
should be configured for IPv6.
@CarmenPopoviciu CarmenPopoviciu removed the skip-pr-description-validation Skip validation of the required PR description format label Oct 21, 2024
@CarmenPopoviciu CarmenPopoviciu merged commit 045787b into main Oct 22, 2024
23 of 24 checks passed
@CarmenPopoviciu CarmenPopoviciu deleted the carmen/proxy-msg branch October 22, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

🐛 BUG: Better error logging in wrangler dev proxy logic
2 participants