Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[D1] fix console output for wrangler d1 migrations create #7197

Merged
merged 2 commits into from
Nov 13, 2024

Conversation

michelheusschen
Copy link
Contributor

@michelheusschen michelheusschen commented Nov 7, 2024

Fixes wrong console output after using wrangler d1 migrations create

Before: /home/user/path/{newMigrationName}
After: /home/user/path/0001_migration.sql


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because: no existing tests, just log output so not worth adding
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: no existing e2e tests print this log message I think
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: messaging change

@michelheusschen michelheusschen requested review from a team as code owners November 7, 2024 18:45
Copy link

changeset-bot bot commented Nov 7, 2024

🦋 Changeset detected

Latest commit: eee106b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Nov 13, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11817469081/npm-package-wrangler-7197

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7197/npm-package-wrangler-7197

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11817469081/npm-package-wrangler-7197 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11817469081/npm-package-create-cloudflare-7197 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11817469081/npm-package-cloudflare-kv-asset-handler-7197
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11817469081/npm-package-miniflare-7197
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11817469081/npm-package-cloudflare-pages-shared-7197
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11817469081/npm-package-cloudflare-vitest-pool-workers-7197
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11817469081/npm-package-cloudflare-workers-editor-shared-7197
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11817469081/npm-package-cloudflare-workers-shared-7197
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11817469081/npm-package-cloudflare-workflows-shared-7197

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.86.1 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241106.0
workerd 1.20241106.1 1.20241106.1
workerd --version 1.20241106.1 2024-11-06

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Copy link
Contributor

@emily-shen emily-shen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this :)

@emily-shen
Copy link
Contributor

For posterity, I tested this manually and it works

Copy link
Contributor

@emily-shen emily-shen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, can you add a changeset please? you can run npx changeset to generate one. This should be a patch. Thanks again!

@michelheusschen
Copy link
Contributor Author

@emily-shen I've added a changeset

@emily-shen emily-shen merged commit 4814455 into cloudflare:main Nov 13, 2024
27 checks passed
@workers-devprod workers-devprod added the contribution [Holopin] Recognizes an open-source contribution, big or small label Nov 13, 2024
Copy link

holopin-bot bot commented Nov 13, 2024

Congratulations @michelheusschen, the maintainer of this repository has issued you a holobyte! Here it is: https://holopin.io/holobyte/cm3fydv7q128720cjzmw4mracc

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution [Holopin] Recognizes an open-source contribution, big or small
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants