Normalize workers assets path #7318
Merged
+176
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 8bc25be The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
WillTaylorDev
force-pushed
the
walshy/normalize-workers-assets-path
branch
from
bf42f5e
to
0e06721
Compare
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11974732616/npm-package-wrangler-7318You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7318/npm-package-wrangler-7318Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11974732616/npm-package-wrangler-7318 dev path/to/script.jsAdditional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11974732616/npm-package-create-cloudflare-7318 --no-auto-updatenpm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11974732616/npm-package-cloudflare-kv-asset-handler-7318npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11974732616/npm-package-miniflare-7318npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11974732616/npm-package-cloudflare-pages-shared-7318npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11974732616/npm-package-cloudflare-vitest-pool-workers-7318npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11974732616/npm-package-cloudflare-workers-editor-shared-7318npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11974732616/npm-package-cloudflare-workers-shared-7318npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11974732616/npm-package-cloudflare-workflows-shared-7318Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
WillTaylorDev
force-pushed
the
walshy/normalize-workers-assets-path
branch
3 times, most recently
from
f252909
to
1fabad5
Compare
WalshyDev
reviewed
Nov 22, 2024
WillTaylorDev
force-pushed
the
walshy/normalize-workers-assets-path
branch
2 times, most recently
from
3f2348a
to
eedc302
Compare
WalshyDev
approved these changes
Nov 22, 2024
WillTaylorDev
force-pushed
the
walshy/normalize-workers-assets-path
branch
from
eedc302
to
8bc25be
Compare
penalosa
approved these changes
Nov 22, 2024
CarmenPopoviciu
approved these changes
Nov 22, 2024
edmundhung
approved these changes
Nov 22, 2024
edmundhung
added
the
skip-pr-description-validation
Merged
| }; | ||
| const BASE_URL = "http://example.com"; | ||
|
|
||
| describe("[Asset Worker] `test redirects`", () => { |
There was a problem hiding this comment.
redirects? or rewrites?
There was a problem hiding this comment.
Good catch, I'll update in my next PR shortly!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents same-schema redirect attacks by collapsing multiple slashes in the path.