This repository has been archived by the owner on Aug 3, 2023. It is now read-only.
Get the audit CI job passing #2151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the following `cargo audit` warning: ``` Crate: tokio Version: 1.13.0 Title: Data race when sending and receiving after closing a `oneshot` channel Date: 2021-11-16 ID: RUSTSEC-2021-0124 URL: https://rustsec.org/advisories/RUSTSEC-2021-0124 Solution: Upgrade to >=1.8.4, <1.9.0 OR >=1.13.1 ``` Versions changed: ``` Updating tokio v1.13.0 -> v1.14.0 Updating tokio-macros v1.5.1 -> v1.6.0 ```
These can't be fixed for now, and are causing us to miss more important audit vulnerabilities.
taylorlee
approved these changes
Dec 10, 2021
threepointone
approved these changes
Dec 13, 2021
Merged
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that I didn't say "fix the vulnerabilities" - this just ignores the
chronoandtimevulnerabilities because they're both very hard to fix and not very common in practice.This uncovered a tokio vulnerability, which I've fixed by upgrading tokio.
cc #2117