Skip to content

Commit

Permalink
polish: s/DO NOT USE THIS/ Ignored (#894)
Browse files Browse the repository at this point in the history
Followup to #888, this replaces some more scary capitals with a more chill word.
  • Loading branch information
threepointone authored May 4, 2022
1 parent b08676a commit 57c1354
Show file tree
Hide file tree
Showing 3 changed files with 19 additions and 10 deletions.
7 changes: 7 additions & 0 deletions .changeset/little-colts-ring.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
"wrangler": patch
---

polish: s/DO NOT USE THIS/ Ignored

Followup to https://github.com/cloudflare/wrangler2/pull/888, this replaces some more scary capitals with a more chill word.
10 changes: 5 additions & 5 deletions packages/wrangler/src/__tests__/configuration.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ describe("normalizeAndValidateConfig()", () => {
expect(diagnostics.hasErrors()).toBe(false);
expect(diagnostics.renderWarnings()).toMatchInlineSnapshot(`
"Processing wrangler configuration:
- 😶 UNUSED: \\"miniflare\\":
- 😶 Ignored: \\"miniflare\\":
Wrangler does not use configuration in the \`miniflare\` section. Unless you are using Miniflare directly you can remove this section."
`);
});
Expand Down Expand Up @@ -571,10 +571,10 @@ describe("normalizeAndValidateConfig()", () => {
expect(diagnostics.hasWarnings()).toBe(true);
expect(diagnostics.renderWarnings()).toMatchInlineSnapshot(`
"Processing wrangler configuration:
- Deprecation: \\"type\\":
DO NOT USE THIS. Most common features now work out of the box with wrangler, including modules, jsx, typescript, etc. If you need anything more, use a custom build.
- Deprecation: \\"webpack_config\\":
DO NOT USE THIS. Most common features now work out of the box with wrangler, including modules, jsx, typescript, etc. If you need anything more, use a custom build."
- 😶 Ignored: \\"type\\":
Most common features now work out of the box with wrangler, including modules, jsx, typescript, etc. If you need anything more, use a custom build.
- 😶 Ignored: \\"webpack_config\\":
Most common features now work out of the box with wrangler, including modules, jsx, typescript, etc. If you need anything more, use a custom build."
`);
});
});
Expand Down
12 changes: 7 additions & 5 deletions packages/wrangler/src/config/validation.ts
Original file line number Diff line number Diff line change
Expand Up @@ -65,23 +65,25 @@ export function normalizeAndValidateConfig(
"miniflare",
"Wrangler does not use configuration in the `miniflare` section. Unless you are using Miniflare directly you can remove this section.",
true,
"😶 UNUSED"
"😶 Ignored"
);

deprecated(
diagnostics,
rawConfig,
"type",
"DO NOT USE THIS. Most common features now work out of the box with wrangler, including modules, jsx, typescript, etc. If you need anything more, use a custom build.",
true
"Most common features now work out of the box with wrangler, including modules, jsx, typescript, etc. If you need anything more, use a custom build.",
true,
"😶 Ignored"
);

deprecated(
diagnostics,
rawConfig,
"webpack_config",
"DO NOT USE THIS. Most common features now work out of the box with wrangler, including modules, jsx, typescript, etc. If you need anything more, use a custom build.",
true
"Most common features now work out of the box with wrangler, including modules, jsx, typescript, etc. If you need anything more, use a custom build.",
true,
"😶 Ignored"
);

validateOptionalProperty(
Expand Down

0 comments on commit 57c1354

Please sign in to comment.