-
Notifications
You must be signed in to change notification settings - Fork 742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wrangler pages dev
compat date and flags
#1663
Conversation
🦋 Changeset detectedLatest commit: 4d0fb44 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.developers.workers.dev/runs/2841327681/npm-package-wrangler-1663 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.developers.workers.dev/prs/1663/npm-package-wrangler-1663 Or you can use npx https://prerelease-registry.developers.workers.dev/runs/2841327681/npm-package-wrangler-1663 dev path/to/script.js |
Codecov Report
@@ Coverage Diff @@
## main #1663 +/- ##
=======================================
Coverage 81.60% 81.61%
=======================================
Files 89 89
Lines 5921 5924 +3
Branches 1520 1522 +2
=======================================
+ Hits 4832 4835 +3
Misses 1089 1089
|
}, | ||
"compatibility-flags": { | ||
describe: "Flags to use for compatibility checks", | ||
alias: "compatibility-flag", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@GregBrimble why the alias? won't this be confusing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/cloudflare/wrangler2/blob/main/packages/wrangler/src/dev.tsx#L117-L123
Just to make it line up with what wrangler dev
does. Both work :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Fixes #495
feat: Adds
--compatibility-date
and--compatibility-flags
towrangler pages dev
Soon to follow in production.