Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrangler pages dev compat date and flags #1663

Merged
merged 1 commit into from
Aug 15, 2022

Conversation

GregBrimble
Copy link
Member

Fixes #495


feat: Adds --compatibility-date and --compatibility-flags to wrangler pages dev

Soon to follow in production.

@changeset-bot
Copy link

changeset-bot bot commented Aug 11, 2022

🦋 Changeset detected

Latest commit: 4d0fb44

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
wrangler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.developers.workers.dev/runs/2841327681/npm-package-wrangler-1663

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.developers.workers.dev/prs/1663/npm-package-wrangler-1663

Or you can use npx with this latest build directly:

npx https://prerelease-registry.developers.workers.dev/runs/2841327681/npm-package-wrangler-1663 dev path/to/script.js

@codecov
Copy link

codecov bot commented Aug 11, 2022

Codecov Report

Merging #1663 (4d0fb44) into main (db592f0) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1663   +/-   ##
=======================================
  Coverage   81.60%   81.61%           
=======================================
  Files          89       89           
  Lines        5921     5924    +3     
  Branches     1520     1522    +2     
=======================================
+ Hits         4832     4835    +3     
  Misses       1089     1089           
Impacted Files Coverage Δ
packages/wrangler/src/api/dev.ts 15.38% <ø> (ø)
packages/wrangler/src/dev.tsx 82.19% <100.00%> (ø)
packages/wrangler/src/pages/dev.tsx 23.35% <100.00%> (+0.46%) ⬆️
packages/wrangler/src/tail/printing.ts 85.71% <0.00%> (-1.79%) ⬇️
packages/wrangler/src/tail/filters.ts 97.87% <0.00%> (+0.04%) ⬆️
...ackages/wrangler/src/__tests__/helpers/mock-bin.ts 100.00% <0.00%> (+5.26%) ⬆️

},
"compatibility-flags": {
describe: "Flags to use for compatibility checks",
alias: "compatibility-flag",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GregBrimble why the alias? won't this be confusing?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/cloudflare/wrangler2/blob/main/packages/wrangler/src/dev.tsx#L117-L123

Just to make it line up with what wrangler dev does. Both work :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@GregBrimble GregBrimble merged commit a9f9094 into main Aug 15, 2022
@GregBrimble GregBrimble deleted the pages-compat-date-and-flags branch August 15, 2022 13:37
@github-actions github-actions bot mentioned this pull request Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Pages Functions does not support compatibility flags
2 participants