-
Notifications
You must be signed in to change notification settings - Fork 735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: switch to rimraf & cross-env for windows support #1675
Conversation
🦋 Changeset detectedLatest commit: d88b500 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.developers.workers.dev/runs/2861026721/npm-package-wrangler-1675 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.developers.workers.dev/prs/1675/npm-package-wrangler-1675 Or you can use npx https://prerelease-registry.developers.workers.dev/runs/2861026721/npm-package-wrangler-1675 dev path/to/script.js |
Codecov Report
@@ Coverage Diff @@
## main #1675 +/- ##
=======================================
Coverage 80.88% 80.88%
=======================================
Files 91 91
Lines 6067 6068 +1
Branches 1555 1556 +1
=======================================
+ Hits 4907 4908 +1
Misses 1160 1160
|
Thanks @Skye-31! It looks like https://github.com/cloudflare/wrangler2/blob/main/package.json already lists |
Co-authored-by: Greg Brimble <gbrimble@cloudflare.com>
Good catch! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you've got an extra space after rimraf
now, but LGTM
Ah yes, I blame that on the GitHub "commit suggestion" thing! |
Related: #1674
Not sure if a changeset is needed for this? Happy to remove if not desired