Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: switch to rimraf & cross-env for windows support #1675

Merged
merged 4 commits into from
Aug 15, 2022

Conversation

Skye-31
Copy link
Contributor

@Skye-31 Skye-31 commented Aug 14, 2022

Related: #1674

Not sure if a changeset is needed for this? Happy to remove if not desired

@changeset-bot
Copy link

changeset-bot bot commented Aug 14, 2022

🦋 Changeset detected

Latest commit: d88b500

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
wrangler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Aug 14, 2022

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.developers.workers.dev/runs/2861026721/npm-package-wrangler-1675

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.developers.workers.dev/prs/1675/npm-package-wrangler-1675

Or you can use npx with this latest build directly:

npx https://prerelease-registry.developers.workers.dev/runs/2861026721/npm-package-wrangler-1675 dev path/to/script.js

@codecov
Copy link

codecov bot commented Aug 14, 2022

Codecov Report

Merging #1675 (d88b500) into main (808c0ab) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1675   +/-   ##
=======================================
  Coverage   80.88%   80.88%           
=======================================
  Files          91       91           
  Lines        6067     6068    +1     
  Branches     1555     1556    +1     
=======================================
+ Hits         4907     4908    +1     
  Misses       1160     1160           
Impacted Files Coverage Δ
packages/wrangler/src/api/dev.ts 15.38% <0.00%> (ø)
packages/wrangler/src/pages/dev.tsx 21.97% <0.00%> (+0.43%) ⬆️

@Cherry
Copy link
Contributor

Cherry commented Aug 14, 2022

Thanks @Skye-31!

It looks like https://github.com/cloudflare/wrangler2/blob/main/package.json already lists cross-env, but rimraf should be added as least as devDependencies here too I think. Tests must be passing due to them being transitive dependencies of something else right now. 😅

packages/wrangler/package.json Outdated Show resolved Hide resolved
.changeset/quiet-readers-smell.md Show resolved Hide resolved
Co-authored-by: Greg Brimble <gbrimble@cloudflare.com>
@Skye-31
Copy link
Contributor Author

Skye-31 commented Aug 15, 2022

Good catch!

Copy link
Member

@GregBrimble GregBrimble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you've got an extra space after rimraf now, but LGTM

@Skye-31
Copy link
Contributor Author

Skye-31 commented Aug 15, 2022

Ah yes, I blame that on the GitHub "commit suggestion" thing!

@Skye-31 Skye-31 merged commit ee30101 into main Aug 15, 2022
@Skye-31 Skye-31 deleted the chore-windows-support branch August 15, 2022 14:03
@github-actions github-actions bot mentioned this pull request Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants