fix: ensure that bundle is generated to es2020 target #815
Conversation
🦋 Changeset detectedLatest commit: c59eb9c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.developers.workers.dev/runs/2177059997/npm-package-wrangler-815You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.developers.workers.dev/prs/815/npm-package-wrangler-815Or you can use npx https://prerelease-registry.developers.workers.dev/runs/2177059997/npm-package-wrangler-815 dev path/to/script.js |
The default tsconfig generated by tsc uses `target: "es5"`, which we don't support. This fix ensures that we output es2020 modules, even if tsconfig asks otherwise.
threepointone
force-pushed
the
explicit-esbuild-target
branch
from
1e88d99 to
c59eb9c
Compare
| `); | ||
| }); | ||
|
|
||
| it("should output to target es2020 even if tsconfig says otherwise", async () => { |
There was a problem hiding this comment.
Should we display a warning in this case?
It could be confusing to developers if that have specified ES5 but it keeps outputting ES2020... They might think that we are not reading tsconfig.json at all?
There was a problem hiding this comment.
They never see the output so it maaay be ok.
The default tsconfig generated by tsc uses
target: "es5", which we don't support. This fix ensures that we output es2020 modules, even if tsconfig asks otherwise.I recommend turning whitespace off for this review.