Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory leak #58

Open
xSirrioNx opened this issue May 18, 2016 · 1 comment
Open

Memory leak #58

xSirrioNx opened this issue May 18, 2016 · 1 comment
Labels

Comments

@xSirrioNx
Copy link

xSirrioNx commented May 18, 2016

<li> elements (PageHandle) not remove with paginator.
You should redefine "remove" method of Paginator like this:

remove: function () {
    if (this.handles) {
        for (var i = 0, l = this.handles.length; i < l; i++) {
            this.handles[i].remove();
        }
    }
    this.undelegateEvents();
    this.$el.removeData().unbind();
    this.stopListening();
    Backbone.View.prototype.remove.call(this);
}
@wyuenho wyuenho added the bug label Jun 8, 2016
@wyuenho
Copy link
Contributor

wyuenho commented Jun 8, 2016

Thanks for reporting this. If you can send over a PR for this it'll be great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants