Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proxy doesn't pass target response status codes through #5

Open
tanyav2 opened this issue Dec 3, 2020 · 0 comments
Open

Proxy doesn't pass target response status codes through #5

tanyav2 opened this issue Dec 3, 2020 · 0 comments
Assignees

Comments

@tanyav2
Copy link
Contributor

tanyav2 commented Dec 3, 2020

Let's assume a query contains a bad key ID. The client will expect to see a 401 response, which is indeed what happens when there is no proxy present:

resp: Response { url: "https://odoh.cloudflare-dns.com/dns-query", status: 401, headers: {"date": "Thu, 03 Dec 2020 ....} }

When a proxy is running, the client instead sees a 200 status code, which makes it much harder for them to accurately flag the issue they are running into:

resp: Response { url: "https://odoh1.surfdomeinen.nl/proxy?targethost=odoh.cloudflare-dns.com&targetpath=%2Fdns-query", status: 200, headers: {"content-length": "0" ...} }
@tanyav2 tanyav2 self-assigned this Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant