[WIP] Add TLS support for Kafka #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the kafka-nozzle should be in separate release. Btw I am now udpating to use the latest nozzle. |
|
A version of this work was merged with #15 |
|
Sorry that I didn't follow up on it back in the day. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isn't ready for merging yet, but opening PR early to garner feedback.
This PR adds TLS support to Kafka, and requires that clients connect with a client certificate.
By way of a demonstration, and to make testing easier, it also includes a
kafka-firehose-nozzlejob, which uses a binary I built based on a corresponding PR that I've sent there, and an operator file that can be added to acf-deploymentthat will create a Zookeeper, a Kafka, and the firehose nozzle - communicating over TLS.What this doesn't do, which it probably should is:
Deal with authentication/authorization/encryption in Zookeeper. We thought we'd start with Kafka as those logs might include user data, but we should probably look at what Zookeeper can do too.
While it authenticates via client certs, it's currently all or nothing. It should have some kind of support for using ACLs within Kafka. We're considering running one big Kafka for multiple CF environments, so that's something we'll likely look at soon.
It doesn't make any updates to
kafka-managerto handle.Anyway, let me know your thoughts.