Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

user should be able to set storage_account_name on a persistent disk #116

Closed
pronoiac opened this issue Mar 30, 2016 · 2 comments
Closed

Comments

@pronoiac
Copy link

so that we can make sure that persistent disk uses specific storage account

users will say something like this:

persistent_disk_pools:
- name: large
  cloud_properties:
    storage_account_name: premiumsotre

and then CPI will receive create_disk CPI call with cloud_properties filled in (https://github.com/cloudfoundry-incubator/bosh-azure-cpi-release/blob/master/src/bosh_azure_cpi/lib/cloud/azure/cloud.rb#L207).

storage_account_name on disk should take precedence over any other configuration (global or VM one).

cc @cppforlife

@AbelHu
Copy link
Contributor

AbelHu commented Mar 31, 2016

@pronoiac When you create VMs on premium storage account, the persistent data disks will be put on the same premium storage account. You do not need to specify storage account name in persistent_disk_pools.

resource_pools:
- name: vms
  network: private
  ...
  cloud_properties:
    storage_account_name: <your_storage_account_name>

@cppforlife
Copy link
Contributor

thats not ideal since disk configuration doesnt really relate to vm info. in fact i may want to create disk on premium storage and create_disk doesnt receive vm id. vm id in create_disk cpi call is on best effort basis.

Sent from my iPhone

On Mar 30, 2016, at 6:22 PM, Chou Hu notifications@github.com wrote:

@pronoiac When you create VMs on premium storage account, the persistent data disks will be put on the same premium storage account. You do not need to specify storage account name in persistent_disk_pools.

resource_pools:

  • name: vms
    network: private
    ...
    cloud_properties:
    storage_account_name: <your_storage_account_name>

    You are receiving this because you were mentioned.
    Reply to this email directly or view it on GitHub

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants