Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump bosh_cpi gem #266

Closed
friegger opened this issue May 12, 2017 · 4 comments
Closed

Bump bosh_cpi gem #266

friegger opened this issue May 12, 2017 · 4 comments
Labels

Comments

@friegger
Copy link

This not really an issue, just a hint. From the vendor folder it looks like you still consume a 1.x bosh_cpiversion. Most current version is 2.1.1. You might consider upgrading.

The current version includes among other things:

  • Returning a Bosh::Clouds::NotImplemented error for not implemented API methods to be more consistent with other CPIs
  • Fix: Registry passwords can now contain %

Kind regards from the OpenStack CPI team

@bingosummer
Copy link
Contributor

@friegger and OpenStack CPI team, thank you for your kindly suggestions. We will consider upgrading.

@bingosummer
Copy link
Contributor

@friegger
I notice that AWS CPI has removed httpclient in Gemfile, but OpenStack CPI still keeps it. Could you please share any particular reason?

@beyhan
Copy link
Member

beyhan commented May 15, 2017

Hi @bingosummer
We don't see any reason for us to keep it because we don't need the httpclient directly. We just missed it. Thanks for the point! With the next update we will remove it.

@AbelHu AbelHu added Done and removed acknowledge labels Jun 1, 2017
@AbelHu
Copy link
Contributor

AbelHu commented Jun 1, 2017

@friegger Close this after merging the PR #273 .

@AbelHu AbelHu closed this as completed Jun 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants