Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow null values in map of service parameters #1159

Merged
merged 1 commit into from
Jul 20, 2022

Conversation

theghost5800
Copy link
Contributor

We hit scenario where service brokers return response including null values and this leads to parsing exception. This is a client limitation and needs to be fixed.

@dmikusa
Copy link
Contributor

dmikusa commented Jul 13, 2022

OK, I'm not opposed to the change. Do you have any more details you can share about the circumstances that contribute to this problem?

It looks like there are cases where the response from server contains a null parameters/credentials data, not an empty map, but it's missing or specifically null? Is that right? I'm just wondering if this is unique to a particular broker? or version of CF?

Thanks

@theghost5800
Copy link
Contributor Author

Hi @dmikusa-pivotal , We had identified recently that some service brokers in CF returns as response map with keys which can be null and this leads to errors in client and we can't continue further. Previously we were using v2 alternative which allows null values in map and we don't have any issues.
So this is missed annotation to be added from my contribution before.

@dmikusa
Copy link
Contributor

dmikusa commented Jul 20, 2022

Understood. Thanks for the PR. Merging.

@dmikusa dmikusa merged commit 4f63c5f into cloudfoundry:main Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants