Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

find_error needs Ruby to be added to path #754

Closed
wendorf opened this issue Dec 20, 2016 · 5 comments
Closed

find_error needs Ruby to be added to path #754

wendorf opened this issue Dec 20, 2016 · 5 comments
Labels

Comments

@wendorf
Copy link
Contributor

wendorf commented Dec 20, 2016

The instructions at https://github.com/cloudfoundry/cloud_controller_ng/blob/master/scripts/find_error#L3-L12 are no longer totally accurate. Ruby must be added to the path first with something like source /var/vcap/jobs/cloud_controller_ng/bin/ruby_version.sh

Should this script just be pre-setup on the VMs? That'd be nice.

@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/136453903

The labels on this github issue will be updated when the story is started.

@thausler786
Copy link
Contributor

@wendorf,

We've fixed the documentation issue in 1474c66, let us know if this is not satisfactory.

As far as the script being pre-setup on the VM, we accept pull requests! I'm also adding a chore to our Pantry for this item (story here: https://www.pivotaltracker.com/story/show/136760429).

If this is satisfactory please go ahead and close the issue!

@wendorf
Copy link
Contributor Author

wendorf commented Dec 29, 2016

Thanks! I think it'd be even more slick if the sourcing happened for you. See my coment on the commit.

@thausler786
Copy link
Contributor

Added! Sourcing now happens for you.

@thausler786 && @michaelxupiv

@wendorf
Copy link
Contributor Author

wendorf commented Dec 29, 2016

Hooray!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants